Skip to content

[feat] rename d_64, h_64 to d_68, h_68 #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpwang merged 1 commit into from
Oct 19, 2023
Merged

[feat] rename d_64, h_64 to d_68, h_68 #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions hashes/zkevm/src/sha256/vanilla/constraints.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ impl<F: Field> Sha256CircuitConfig<F> {
let mut f = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut g = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut h = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut d_64 = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut h_64 = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut d_68 = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut h_68 = vec![0u64.expr(); NUM_BITS_PER_WORD];
let mut new_a_ext = vec![0u64.expr(); NUM_BITS_PER_WORD_EXT];
let mut new_e_ext = vec![0u64.expr(); NUM_BITS_PER_WORD_EXT];
meta.create_gate("Query state bits", |meta| {
Expand All @@ -85,8 +85,8 @@ impl<F: Field> Sha256CircuitConfig<F> {
f[i] = meta.query_advice(word_e[k], Rotation(-2));
g[i] = meta.query_advice(word_e[k], Rotation(-3));
h[i] = meta.query_advice(word_e[k], Rotation(-4));
d_64[i] = meta.query_advice(word_a[k], Rotation(-((NUM_ROUNDS + 4) as i32)));
h_64[i] = meta.query_advice(word_e[k], Rotation(-((NUM_ROUNDS + 4) as i32)));
d_68[i] = meta.query_advice(word_a[k], Rotation(-((NUM_ROUNDS + 4) as i32)));
h_68[i] = meta.query_advice(word_e[k], Rotation(-((NUM_ROUNDS + 4) as i32)));
}
for k in 0..NUM_BITS_PER_WORD_EXT {
new_a_ext[k] = meta.query_advice(word_a[k], Rotation(0));
Expand Down Expand Up @@ -189,12 +189,12 @@ impl<F: Field> Sha256CircuitConfig<F> {
cb.require_equal(
"end a",
decode::expr(&new_a_ext),
decode::expr(&d) + decode::expr(&d_64),
decode::expr(&d) + decode::expr(&d_68),
);
cb.require_equal(
"end e",
decode::expr(&new_e_ext),
decode::expr(&h) + decode::expr(&h_64),
decode::expr(&h) + decode::expr(&h_68),
);
cb.gate(meta.query_fixed(q_end, Rotation::cur()))
});
Expand Down