Skip to content

[chore] change gate annotation for better debugging #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpwang merged 1 commit into from
Oct 19, 2023
Merged

[chore] change gate annotation for better debugging #188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions hashes/zkevm/src/sha256/vanilla/constraints.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@ impl<F: Field> Sha256CircuitConfig<F> {
|cb| {
// Input bytes need to be zero, or 128 if this is the first padding byte
cb.require_equal(
"padding start/intermediate byte",
"padding start/intermediate byte, all padding rows except the last one",
input_bytes[idx].clone(),
is_first_padding.expr() * 128.expr(),
);
Expand All @@ -309,7 +309,7 @@ impl<F: Field> Sha256CircuitConfig<F> {
|cb| {
// Input bytes need to be zero, or 128 if this is the first padding byte
cb.require_equal(
"padding start/intermediate byte",
"padding start/intermediate byte, last padding row but not in the final block",
input_bytes[idx].clone(),
is_first_padding.expr() * 128.expr(),
);
Expand Down