Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when loading conflicting translation keys #78

Closed
3 tasks done
axieum opened this issue Jun 10, 2023 · 0 comments · Fixed by #80
Closed
3 tasks done

Crashes when loading conflicting translation keys #78

axieum opened this issue Jun 10, 2023 · 0 comments · Fixed by #80
Assignees
@axieum
Labels
bug Something isn't working minecord-api Improvements or additions to the api module

Comments

@axieum
Copy link
Owner

axieum commented Jun 10, 2023 •
edited
Loading

Expected behavior

For modded translation files that overwrite existing keys to be loaded successfully.

Observed/actual behavior

Multiple entries with same key: entity.minecraft.villager.none=Unemployed and entity.minecraft.villager.none=Villager

It appears that Fabric API is now loading en_us.json from mod containers here:

FabricMC/fabric@40630ee

Steps/models to reproduce

Install a mod that adds translations and boot the server.

Version

v2.0.0+1.20

Agreements

  • I am running the latest version of the mod.
  • My version of Minecraft is supported.
  • I have searched for and ensured there isn't already an open issue regarding this.

Other

No response
axieum added a commit that referenced this issue Jun 10, 2023
@axieum
fix(api): do not load already loaded modded translations (fixes #78)
c71b1bb
@axieum axieum self-assigned this Jun 10, 2023
@axieum axieum added bug Something isn't working minecord-api Improvements or additions to the api module labels Jun 10, 2023
@axieum axieum closed this as completed in d6614bd Jun 10, 2023
@github-actions github-actions bot mentioned this issue Jun 10, 2023
Merged
axieum added a commit that referenced this issue Jun 10, 2023
@axieum
fix(api): do not load already loaded modded translations (fixes #78) (#…
2aaf1ba 
…79)

(cherry picked from commit d6614bd)
@github-actions github-actions bot mentioned this issue Jun 10, 2023
Merged
@github-actions github-actions bot mentioned this issue Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@axieum axieum

Labels
bug Something isn't working minecord-api Improvements or additions to the api module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: release v2.0.1+1.20 axieum/minecord
chore: release v axieum/minecord
1 participant
@axieum