consortium-v2: explicitly name conditional check in snapshot's apply #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
requested review from
huyngopt1994,
andicrypt,
Francesco4203 and
tien-nguyen-sm
minh-bq
force-pushed
the
cleanup/snapshot
branch
from
0f78428
to
ec18a8a
Compare
tien-nguyen-sm
approved these changes
Nov 14, 2024
Francesco4203
approved these changes
Nov 14, 2024
This is a refactor commit that explicitly name some hard to understand conditional checks in snapshot's apply. It also adds more comments to snapshot fields.
minh-bq
force-pushed
the
cleanup/snapshot
branch
from
ec18a8a
to
fb562b0
Compare
huyngopt1994
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor commit that explicitly name some hard to understand conditional checks in snapshot's apply. It also adds more comments to snapshot fields.