Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miner/worker: skip the uncle and resubmit logic in Consortium #406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

minh-bq
Copy link
Contributor

@minh-bq minh-bq commented Feb 22, 2024

  • miner/worker: skip the uncle logic in Consortium

In Consortium consensus engine, we don't handle uncle blocks. Furthermore, the
uncle logic in worker may block the main creating block logic. So this commit
skips the uncle logic when Consortium consensus engine is used.

  • miner/worker: skip resubmit logic in Consortium

Currently, after 3 seconds, worker tries to create another block, optimistically
thinks that it can get more transactions and earns more fee as a result.
However, this causes overhead to the main block creating flow, so skip this
logic in Consortium.

In Consortium consensus engine, we don't handle uncle blocks. Furthermore, the
uncle logic in worker may block the main creating block logic. So this commit
skips the uncle logic when Consortium consensus engine is used.
Currently, after 3 seconds, worker tries to create another block, optimistically
thinks that it can get more transactions and earns more fee as a result.
However, this causes overhead to the main block creating flow, so skip this
logic in Consortium.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant