Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/metrics #3

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Bugfix/metrics #3

merged 2 commits into from
Aug 23, 2022

Conversation

ssscrom
Copy link
Contributor

@ssscrom ssscrom commented Aug 22, 2022

Renamed all metrics by replacing '/' with '_'
Fixed issues where AddGauge did not record its created instance.
Fixed issues where Start stopped running after a loop.

…AddGauge and AddHistogram where instances were not recorded for later usage. Pusher.Start now will loop properly
Copy link
Contributor

@minh-bq minh-bq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

adapters/prometheus/pusher.go Show resolved Hide resolved
@ssscrom ssscrom merged commit c7ef342 into master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants