Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upstream parity #8

Merged
merged 2 commits into from
Mar 29, 2019
Merged

Update upstream parity #8

merged 2 commits into from
Mar 29, 2019

Conversation

s1na
Copy link
Collaborator

@s1na s1na commented Feb 15, 2019

This PR updates the parity-ethereum to v2.3.3, and fixes the breaking api changes that have happened. Build doesn't fail anymore, but I didn't know how to test it!

@s1na
Copy link
Collaborator Author

s1na commented Mar 14, 2019

Updated the build script to use chisel instead of wasm-gc, and replaced stat -f%z with wc -c which is more portable (stat didn't work for me).

I was also able to instantiate the module from js.

This was referenced Mar 15, 2019
@axic
Copy link
Owner

axic commented Mar 27, 2019

It seems upstream is so unstable that now it doesn't compile anymore:

    Updating git repository `https://github.com/ewasm/ewasm-rust-api`                                                                                                    
    Updating git repository `https://github.com/paritytech/parity-common`                                                                                                
error: no matching package named `patricia-trie` found                                                                                                                   
location searched: https://github.com/paritytech/parity-common
required by package `vm v0.1.0 (/Users/alex/Projects/runevm/parity-ethereum/ethcore/vm)`
    ... which is depended on by `runevm v0.1.0 (/Users/alex/Projects/runevm)`

@s1na
Copy link
Collaborator Author

s1na commented Mar 28, 2019

I did a fresh clone to test and it seems to work. Is your submodule on openethereum/parity-ethereum@3b9b1a8?

@axic
Copy link
Owner

axic commented Mar 29, 2019

My bad, it did work on another fresh install.

@axic axic merged commit e210881 into axic:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants