CI: test via hera and testeth #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
May 20, 2019
axic
approved these changes
May 22, 2019
axic
force-pushed
the
ci/testeth
branch
5 times, most recently
from
d9d2195
to
cd14f42
Compare
|
The reason this was failing with the shift tests: ethereum/aleth#5617 The reason it didn't fail on Hera: Hera uses a year old fork on the test suite. |
axic
force-pushed
the
ci/testeth
branch
2 times, most recently
from
5ffbec4
to
c2ef5a5
Compare
The main one fails when running Byzantium-only tests.
axic
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ewasm/hera#513 being released
Fixes #24