Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: reduce dependency pain by moving to better maintained libs #342

Merged
merged 5 commits into from
Mar 2, 2024

Conversation

axe312ger
Copy link
Owner

@axe312ger axe312ger commented Mar 2, 2024

node-vibrant didnt get any updates for some years. This leads to a lot of old and unnessecary dependencies.

This updates to the more and better maitained fork at https://github.com/GriffinJohnston/sharp-vibrant

same for potrace, moving to @gatsbyjs/potrace as the gatsbyjs team is so nice to keep dependencies up 2 date

@axe312ger axe312ger added this to the 1.0.0 milestone Mar 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 87.40%. Comparing base (0cc6918) to head (bba821a).
Report is 3 commits behind head on master.

Files Patch % Lines
packages/sqip/src/sqip.ts 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   87.27%   87.40%   +0.13%     
==========================================
  Files          11       11              
  Lines         550      548       -2     
  Branches       90       89       -1     
==========================================
- Hits          480      479       -1     
+ Misses         62       61       -1     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@axe312ger axe312ger changed the title refactor: reduce dependency pain by moving to better maintained vibrant lib refactor: reduce dependency pain by moving to better maintained libs Mar 2, 2024
@axe312ger
Copy link
Owner Author

Great! The more modern dependencies seem together with the removal of probe-image-size are faster!

Old:
Screenshot 2024-03-02 at 17 02 44

New:

Screenshot 2024-03-02 at 17 01 53

@axe312ger axe312ger merged commit ac139a7 into master Mar 2, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants