Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from feGaussianBlur to CSS filter:blur #335

Open
xerc opened this issue Feb 8, 2024 · 5 comments
Open

Switch from feGaussianBlur to CSS filter:blur #335

xerc opened this issue Feb 8, 2024 · 5 comments
Milestone

Comments

@xerc
Copy link
Contributor

xerc commented Feb 8, 2024

<g filter="url(#prefix__a)"
svg-feGaussianBlur

<g filter="blur(12px)"
css-filter-blur

ref. https://axe312ger.github.io/sqip/processed/charles-550068-unsplash-sqip.svg

xerc added a commit to xerc/sqip that referenced this issue Feb 8, 2024
@axe312ger
Copy link
Owner

axe312ger commented Feb 19, 2024

Thank you for the suggest, css blur looks better but:

  1. browser support is questionable (at least it was a few years ago)
  2. it (was) much worse in performance as the svg blur

I am happy to give an option so the user can decide which blur to choose. Maybe we can do some rendering performance testing as well?

@xerc
Copy link
Contributor Author

xerc commented Feb 19, 2024

1. browser support is questionable (at least it was a few years ago)

true ; not @ IE

2. it (was) much worse in performance as the svg blur

could find any benchmarks from 2k+

I am happy to give an option so the user can decide which blur to choose.

good idea

Maybe we can do some rendering performance testing as well?

@ chromium [120.0.6092.0] filter:blur seems faster (3 reloads)

Bildschirmfoto 2024-02-19 um 20 23 19
Bildschirmfoto 2024-02-19 um 20 23 06

@axe312ger
Copy link
Owner

axe312ger commented Feb 20, 2024

For reference, here is the browser support:

@axe312ger
Copy link
Owner

axe312ger commented Feb 20, 2024

Honestly, support is the same (today!) and IE doesnt support either blur technique is not relevant anymore. Luckily its 2024.

@axe312ger
Copy link
Owner

It would be really cool if we could change our demo, or make another sub page for each blur with a lot of example images. Then we can render each page multiple times in a controlled environment (some CI) and compare the rendering results.

Based on this, we can give the users some details about the impact on which blur they choose, plus maybe switch to the css blur filter as default

@axe312ger axe312ger added this to the 1.0.0 milestone Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants