IN-166 Automox XSOAR Unit Tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for key_string in excluded_keys_list: | ||
| keys = key_string.split(".") | ||
| data = remove_key(keys, data) | ||
|
|
||
| return data | ||
|
|
||
| def remove_key(keys_to_traverse, data): | ||
|
|
||
| def remove_key(keys_to_traverse: List[str], data: Dict[str, Any]) -> Dict[str, Any]: |
There was a problem hiding this comment.
any concerns with recursion depth here?
|
|
||
| org_id = 1 | ||
|
|
||
| expected_response = util_load_json("./test_data/automox-group-create.json") |
There was a problem hiding this comment.
This had to have been annoying 😂
ax-tschmidtke
approved these changes
Mar 31, 2022
ax-jmiller
added a commit
that referenced
this pull request
May 23, 2022
* Automox Content Pack for XSOAR (#1) * IN-104 Implemented commands related to Administration and Vulnerability Sync use cases. * [IN-149] Adding Vulnerability Upload Playbook (#2) Added playbook to automate report uploads * [IN-152] Automox XSOAR Documentation (#3) Added documentation for Playbook, Integration, and Pack * IN-166 Automox XSOAR Unit Tests (#4) * Adding unit tests * Reviewed checklist for XSOAR submission * Cleaning up integration test files * Fixed validation issues with playbook * Updated README and Integration yaml to be consistent with args in Python. Fixed issues with fromversion and tests in Integration yaml. * Playbook documentation updates regarding supported csv formats * Present errors in a pleasant and readable way. Handled basic http fail codes * Updated delete commands to update objects in the context with deleted key * Removed test playbook from integration yaml Co-authored-by: MLainer1 <[email protected]> * Added Automox integration instrumentation * Fixed docker image version and schema validation in integration yaml Co-authored-by: MLainer1 <[email protected]> Co-authored-by: Jack Miller <[email protected]> Co-authored-by: MLainer1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Screenshots
Paste here any images that will help the reviewer
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have