-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade AWS SDK to 2.25.10 #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejwalkowiak
requested review from
MatejNedic and
tomazfernandes
as code owners
March 4, 2024 10:00
github-actions
bot
added
component: cloudwatch
CloudWatch integration related issue
component: dynamodb
DynamoDB integration related issue
component: parameter-store
Parameter Store integration related issue
component: s3
S3 integration related issue
component: secrets-manager
Secrets Manager integration related issue
component: sns
SNS integration related issue
component: sqs
SQS integration related issue
type: dependency-upgrade
Dependency version bump
labels
Mar 4, 2024
MatejNedic
reviewed
Mar 8, 2024
@@ -63,7 +64,7 @@ class SnsTemplateIntegrationTest { | |||
|
|||
@Container | |||
static LocalStackContainer localstack = new LocalStackContainer( | |||
DockerImageName.parse("localstack/localstack:2.3.2")).withServices(SQS).withReuse(true); | |||
DockerImageName.parse("localstack/localstack:3.2.0")).withServices(SNS, SQS).withReuse(true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets remove withServices
since it is not used anymore
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: cloudwatch
CloudWatch integration related issue
component: dynamodb
DynamoDB integration related issue
component: parameter-store
Parameter Store integration related issue
component: s3
S3 integration related issue
component: secrets-manager
Secrets Manager integration related issue
component: sns
SNS integration related issue
component: sqs
SQS integration related issue
type: dependency-upgrade
Dependency version bump
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.