Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump d3-color to 3.1.0, add postinstall hook to fix export path #167

Merged
merged 1 commit into from
Oct 19, 2022
Merged

chore: bump d3-color to 3.1.0, add postinstall hook to fix export path #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/synchro-charts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@
"copy:contributing": "cp ../../CONTRIBUTING.md CONTRIBUTING.md",
"prepack": "yarn run copy:license && yarn run copy:notice && yarn run copy:code-of-conduct && yarn run copy:contributing",
"prepublishOnly": "yarn release",
"pack": "yarn pack"
"pack": "yarn pack",
"postinstall": "node postinstall.js"
},
"devDependencies": {
"@babel/core": "^7.6.4",
Expand Down Expand Up @@ -101,6 +102,7 @@
"d3-array": "^2.3.2",
"d3-axis": "^1.0.12",
"d3-brush": "^1.1.3",
"d3-color": "3.1.0",
"d3-drag": "^1.2.5",
"d3-scale": "^3.2.0",
"d3-selection": "^1.3.1",
Expand All @@ -122,5 +124,8 @@
"uuid": "^3.3.2",
"validator": "^13.6.0"
},
"resolutions": {
"d3-color": "3.1.0"
},
"license": "Apache-2.0"
}
10 changes: 10 additions & 0 deletions packages/synchro-charts/postinstall.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
// We need to use the UMD version of the d3-color package, but we also
// need to bump to a version where the ESM version has been made the default
// due to a vulnerability (see https://github.com/d3/d3-color/issues/97).
// Yarn v1 does not understand the package.json "exports" property, so we
// must write the UMD export path into the "main" property.
const d3ColorPackageJsonPath = '/node_modules/d3-color/package.json';
// eslint-disable-next-line import/no-dynamic-require
const d3ColorPackageJson = require(process.cwd() + d3ColorPackageJsonPath);
d3ColorPackageJson.main = d3ColorPackageJson.exports.umd;
require('fs').writeFileSync(process.cwd() + d3ColorPackageJsonPath, JSON.stringify(d3ColorPackageJson, null, 2));
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6217,6 +6217,11 @@ d3-color@1:
resolved "https://registry.yarnpkg.com/d3-color/-/d3-color-2.0.0.tgz#8d625cab42ed9b8f601a1760a389f7ea9189d62e"
integrity sha512-SPXi0TSKPD4g9tw0NMZFnR95XVgUZiBH+uUTqQuDu1OsE2zomHU7ho0FISciaPvosimixwHFl3WHLGabv6dDgQ==

[email protected]:
version "3.1.0"
resolved "https://registry.yarnpkg.com/d3-color/-/d3-color-3.1.0.tgz#395b2833dfac71507f12ac2f7af23bf819de24e2"
integrity sha512-zg/chbXyeBtMQ1LbD/WSoW2DpC3I0mpmPdW+ynRTj/x2DAWYrIY7qeZIHidozwV24m4iavr15lNwIwLxRmOxhA==

d3-dispatch@1:
version "1.0.6"
resolved "https://registry.yarnpkg.com/d3-dispatch/-/d3-dispatch-1.0.6.tgz#00d37bcee4dd8cd97729dd893a0ac29caaba5d58"
Expand Down