-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sockeye 2 heafield quantize pr2 #812
Merged
mjdenkowski
merged 3 commits into
sockeye_2_heafield_quantize
from
sockeye_2_heafield_quantize_pr2
May 22, 2020
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,2 @@ | ||
horovod==0.18.1 | ||
horovod==0.19.1 | ||
mpi4py |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Copyright 2020 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"). You may not | ||
# use this file except in compliance with the License. A copy of the License | ||
# is located at | ||
# | ||
# http://aws.amazon.com/apache2.0/ | ||
# | ||
# or in the "license" file accompanying this file. This file is distributed on | ||
# an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either | ||
# express or implied. See the License for the specific language governing | ||
# permissions and limitations under the License. | ||
|
||
import argparse | ||
import logging | ||
import os | ||
|
||
import sockeye.constants as C | ||
from sockeye.log import setup_main_logger, log_sockeye_version | ||
import sockeye.model | ||
from sockeye.utils import check_condition | ||
|
||
logger = logging.getLogger(__name__) | ||
|
||
|
||
def main(): | ||
setup_main_logger(console=True, file_logging=False) | ||
params = argparse.ArgumentParser( | ||
description='Annotate trained model with scaling factors for fast loading/quantization for int8 inference.') | ||
params.add_argument('--model', '-m', required=True, help='Trained Sockeye model directory.') | ||
args = params.parse_args() | ||
|
||
log_sockeye_version(logger) | ||
|
||
params_best = os.path.join(args.model, C.PARAMS_BEST_NAME) | ||
params_best_float32 = os.path.join(args.model, C.PARAMS_BEST_NAME_FLOAT32) | ||
config = os.path.join(args.model, C.CONFIG_NAME) | ||
config_float32 = os.path.join(args.model, C.CONFIG_NAME_FLOAT32) | ||
|
||
for fname in params_best_float32, config_float32: | ||
check_condition(not os.path.exists(fname), | ||
'File "%s" exists, indicating this model has already been quantized.' % fname) | ||
|
||
# Load model and compute scaling factors | ||
model = sockeye.model.load_model(args.model, for_disk_saving='float32', dtype='int8') | ||
# Move original params and config files | ||
os.rename(params_best, params_best_float32) | ||
os.rename(config, config_float32) | ||
# Write new params and config files with annotated scaling factors | ||
model[0].save_parameters(params_best) | ||
model[0].save_config(args.model) | ||
|
||
|
||
if __name__ == '__main__': | ||
main() |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code below could also be moved into another function with only one string argument to avoid calling main functions in a library use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good idea.