Move server specific methods from Protocol to ServerProtocol #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlbarber
changed the title
hlbarber
force-pushed
the
harryb/move-protocol-to-server-protocol
branch
from
47f54bd
to
e348c8f
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
david-perez
approved these changes
Sep 13, 2022
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Signed-off-by: Daniele Ahmed <[email protected]>
…ove-protocol-to-server-protocol
hlbarber
force-pushed
the
harryb/move-protocol-to-server-protocol
branch
from
c2a67d1
to
54cc60e
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#1698
Description
Move server specific methods from
ProtocolontoServerProtocol.