-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate Protocol class into CoreProtocol, ServerProtocol, and ClientProtocol #1698
Comments
Related progress towards this goal: #1697 |
The |
Rather than have this be the case, it's probably more ergonomic to have Changes have been made in #1693 to do this for the server side. |
At the time of writing, there is a single
Protocol
class which holds both client and server methods, despite it living inside thecodegen
folder. Thecodegen
folder is supposed to be server agnostic.We should separate
Protocol
interface intoCoreProtocol
,ServerProtocol
, andClientProtocol
interfaces.CoreProtocol
holds methods common to both the server and client.ServerProtocol
holds an instance ofCoreProtocol
and lives in thecodegen-server
.ClientProtocol
should work similarly toServerProtocol
- encapsulating all client specific methods and living in an appropriate space.As a result, the classes implementing
Protocol
should also be separated. For example:class CoreRestJsonProtocol: CoreProtocol
class ServerRestJsonProtocol: ServerProtocol
class ClientRestJsonProtocol: ClientProtocol
and methods should be added to
Server{Protocol}Protocol
andClient{Protocol}Protocol
to retrieveCore{Protocol}Protocol
.The text was updated successfully, but these errors were encountered: