Flatten and remove mixins from code generation #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
Aug 29, 2022
codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/smithy/RustCodegenPlugin.kt
Outdated
Show resolved
Hide resolved
jdisanti
reviewed
Aug 30, 2022
codegen/src/main/kotlin/software/amazon/smithy/rust/codegen/testutil/TestHelpers.kt
Outdated
Show resolved
Hide resolved
codegen/src/test/kotlin/software/amazon/smithy/rust/codegen/smithy/BaselineTransformTest.kt
Outdated
Show resolved
Hide resolved
codegen/src/test/kotlin/software/amazon/smithy/rust/codegen/smithy/BaselineTransformTest.kt
Outdated
Show resolved
Hide resolved
...er/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ServerCodegenVisitor.kt
Outdated
Show resolved
Hide resolved
DavidOgunsAWS
requested review from
a team,
crisidev and
david-perez
as code owners
DavidOgunsAWS
force-pushed
the
mixins
branch
from
ae5ab86
to
7311973
Compare
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
jdisanti
approved these changes
Sep 3, 2022
...rc/test/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ServerCodegenVisitorTest.kt
Outdated
Show resolved
Hide resolved
codegen/src/test/kotlin/software/amazon/smithy/rust/codegen/smithy/CodegenVisitorTest.kt
Outdated
Show resolved
Hide resolved
david-perez
approved these changes
Sep 6, 2022
…r server codegen.
…t class and test case.
DavidOgunsAWS
force-pushed
the
mixins
branch
from
b8dd789
to
8cc1213
Compare
jdisanti
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The intent of mixins is convenience for service model authors to compose shapes with usable members and traits. These shapes should not be visible products in client SDK or even service implementations as only the final target shape really represents the intended public object interface.
Description
At the start of processing, use a ModelTransformer method to flatten and remove mixins from the model. This prevents any part of code generation from knowing what the mixins are.
Testing
Manual testing so far.
Checklist
CHANGELOG.next.tomlif I made changes to the smithy-rs codegen or runtime cratesCHANGELOG.next.tomlif I made changes to the AWS SDK, generated SDK code, or SDK runtime cratesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.