-
Couldn't load subscription status.
- Fork 26
New work around for fork with multithread from CRT #320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @TingDaoK for implementing a solution to address the fork compatibility issue in CRT S3 client. These changes should enhance the experience for users who rely on fork functionality.
Description
Previously, since the underlying CRT client has multiple background threads, there are couple hacks have done to workaround the fork issue. Notes: overall, fork with multi-threading is not encouraged and not well supported.
Well, it works mostly.
CRT has some global state related to threads (There may be more than what I listed, I just listed what I have found so far)
Given the findings above, a better workaround is to drop the CRT S3 client and then wait for CRT background threads to join, which will at least get around the two findings listed above. Printout warnings for user about the potential risk.
THIS IS JUST A PROVE OF CONCEPT, feel free to take over the branch 🙇♂️
Additional context
Related items
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.