Skip to content

Conversation

@aire-meta-bot
Copy link
Collaborator

This PR is auto-generated by Github Action Bot.

Please check the CI results before merge it.
If one or more tests failed, please commit necessary changes to this branch (update-submodule-tvm-2022-08-22-13-17-00).

If there are more than one PRs like this, please keep the latest one and manually close others.

cc @awslabs/raf-committer

@comaniac
Copy link
Contributor

TVM has upgraded to use C++17 for compilation (apache/tvm#12337), and the codebase is no longer compatible with C++11 anymore due to the use of std::string_view (apache/tvm@d2f9f25).

Accordingly, RAF is upgraded to use C++17 since this PR. However, the nvcc compilation with c++17 raised the following error:

raf/include/raf/././ir_ext.h:71:33: error: 'may_sharetvm' has not been declared
  mutable Var may_share{Var()};

The include chain is *.cu -> kernel_utils.chu -> device.h -> ir.h -> ir_ext.h. I removed the dependency from ir.h to ir_ext.h to let *.cu files not include ir_ext.h and the problem is solved, although I still don't know the root cause. Meanwhile, with this change, #include "raf/ir.h" no longer includes ir_ext.h and dataflow_pattern.h implicitly, so I changed header files to directly include them if needed.

cc @hgt312 @yzhliu

@comaniac comaniac force-pushed the update-submodule-tvm-2022-08-22-13-17-00 branch from 3cdb139 to 81d633f Compare August 22, 2022 21:12
Copy link
Member

@hgt312 hgt312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@comaniac comaniac merged commit 9e36319 into main Aug 23, 2022
@comaniac
Copy link
Contributor

Thanks @hgt312

@comaniac comaniac deleted the update-submodule-tvm-2022-08-22-13-17-00 branch September 27, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants