Skip to content

Conversation

@aire-meta-bot
Copy link
Collaborator

This PR is auto-generated by Github Action Bot.

Please check the CI results before merge it.
If one or more tests failed, please commit necessary changes to this branch (update-submodule-tvm-2022-07-18-13-17-36).

If there are more than one PRs like this, please keep the latest one and manually close others.

cc @awslabs/raf-committer

@comaniac
Copy link
Contributor

Looks like there are a change in TVM that breaks our roi_align_dx.

Failed cases on CPU:

[2022-07-18T13:57:50 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NCHW-avg-config0]
[2022-07-18T13:57:50 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NCHW-max-config0]
[2022-07-18T13:57:50 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NHWC-avg-config0]
[2022-07-18T13:57:50 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NHWC-max-config0]

Failed cases on GPU:

[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NCHW-avg-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NCHW-max-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NHWC-avg-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cpu-NHWC-max-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cuda-NCHW-avg-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cuda-NCHW-max-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cuda-NHWC-avg-config0]
[2022-07-18T14:38:46 UTC] FAILED tests/python/op/tvm/test_tvm_vision.py::test_roi_align[cuda-NHWC-max-config0]

Errors:

[2022-07-18T13:57:50 UTC] E   TVMError: Cannot find a valid dispatch for op raf.op.roi_align_dx:
[2022-07-18T13:57:50 UTC] E   [TVM] Failed to JIT: raf_op_tvm_roi_align_dx_6: TVMError: 
[2022-07-18T13:57:50 UTC] E   ---------------------------------------------------------------
[2022-07-18T13:57:50 UTC] E   An error occurred during the execution of TVM.
[2022-07-18T13:57:50 UTC] E   For more information, please see: https://tvm.apache.org/docs/errors.html
[2022-07-18T13:57:50 UTC] E   ---------------------------------------------------------------
[2022-07-18T13:57:50 UTC] E     Check failed: (ExprDeepEqual()(old_info.max(), info.max())) is false: Trying to update var 'rh' with a different maximum value: original=(int32(tir.ceil((max((placeholder[i, 4] - placeholder[i, 2]), 1f)/7f))) - 1), new=(int32(tir.ceil((max((placeholder[i, 4] - placeholder[i, 2]), 1f)*0.142857f))) - 1)
[2022-07-18T13:57:50 UTC] tvm/_ffi/_cython/./base.pxi:181: TVMError

@hgt312 PTAL. Thanks.

@hgt312
Copy link
Member

hgt312 commented Jul 19, 2022

it's due to apache/tvm#11970, I file a issue to tvm about it
apache/tvm#12126

@comaniac comaniac merged commit 7a850e7 into main Jul 20, 2022
@comaniac
Copy link
Contributor

I marked roi_align tests as xfail and mentioned the TVM issue in the fail reason, so that we could pass the CI and merge this PR first.

@comaniac comaniac deleted the update-submodule-tvm-2022-07-18-13-17-36 branch July 20, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants