This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
fix nightly on sgd #225
Merged
fix nightly on sgd #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
failed tests reduce from 37 to 5, need to fix some other ops impacted. |
|
waiting for the fix on mxnet to go in nightly build |
|
@sandeep-krishnamurthy @karan6181 could you help take a look? Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nightly test failed due to an update from MXNet side on SGD optimizer:
apache/mxnet#13346
changed SGD optimizer in mxnet backend accordingly, and set aggregate_num=1, as Keras optimizer do it 1 at a time.