-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: freeze & run Black version 24.02
#3131
Conversation
24.01
24.01
This test is failing but only on py3.8 so it is strange and maybe flaky? |
Flaky test |
playing with flaky over here: #3132 |
@lostella mind checking it again, pls 🐿️ |
24.01
24.02
@lostella, if you would have a chance to check it, it would be great to finish it 🦩 |
@lostella, is there still anything I need to change? 🐿️ |
@Borda maybe it's better not to freeze the black version. For example, vulnerabilities are found in black versions prior to 24.3.0, see https://github.com/awslabs/gluonts/security/dependabot/17 |
@lostella I see your point but from developer's perspective it is easier to have it frozen so you won't si sudden changes or broken lint, which would be unrelated to a contributor work, but instead move the black version to |
yes, I think that would be much better! |
OK so, could we please land this with just update and I will prepare another with the automated process so it is separately and easier to review... |
*Issue #, if available:* set a single black version to ensure reproducibility UPDATE: seem that the latest Black would need to be applied *Description of changes:* freeze Black version, but the better way is in awslabs#3111 By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup cc: @jaheba @kashif @lostella
Issue #, if available:
set a single black version to ensure reproducibility
UPDATE: seem that the latest Black would need to be applied
Description of changes:
freeze Black version, but the better way is in #3111
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup
cc: @jaheba @kashif @lostella