-
Notifications
You must be signed in to change notification settings - Fork 744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: chain requirements to ensure compatibility #3112
Conversation
@Borda thanks! I guess let's wait for all checks to be green before coming back to this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Borda! Just needs rebasing
5717472
to
bf3e0e9
Compare
@lostella done; just curious why rebasing and not just merging the |
whatever works :-) what I meant is to update the branch so that CI workflows run |
If possible, I would suggest dropping |
we can also move the pytorch version to 2.x no? |
probably but lets make it as separate PR 🐔 |
Yeah we should get rid of that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
*Issue #, if available:* atm, all install requirements are installed as stand-alone, which means if there is a version collision, `pip` does not care about it, and so for eventual version compatibility, a collision may not be discovered *Description of changes:* just install all needed requirements for the particular job at once so pip sees all required packages and finds an intersection among all :flags: By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice. cc: @jaheba @kashif @lostella kind ling as it seems there are no revivers by default 🐿️ **Please tag this pr with at least one of these labels to make our release process faster:** BREAKING, new feature, bug fix, other change, dev setup
Issue #, if available: atm, all install requirements are installed as stand-alone, which means if there is a version collision,
pip
does not care about it, and so for eventual version compatibility, a collision may not be discoveredDescription of changes:
just install all needed requirements for the particular job at once so pip sees all required packages and finds an intersection among all 🎏
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
cc: @jaheba @kashif @lostella kind ling as it seems there are no revivers by default 🐿️
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup