Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: chain requirements to ensure compatibility #3112

Merged
merged 8 commits into from
Feb 7, 2024
Merged

CI: chain requirements to ensure compatibility #3112

merged 8 commits into from
Feb 7, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Jan 29, 2024 •
edited
Loading

Issue #, if available: atm, all install requirements are installed as stand-alone, which means if there is a version collision, pip does not care about it, and so for eventual version compatibility, a collision may not be discovered

Description of changes:
just install all needed requirements for the particular job at once so pip sees all required packages and finds an intersection among all 🎏

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

cc: @jaheba @kashif @lostella kind ling as it seems there are no revivers by default 🐿️

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella
Copy link
Contributor

lostella commented Feb 1, 2024

@Borda thanks! I guess let's wait for all checks to be green before coming back to this

lostella
lostella previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Borda! Just needs rebasing

@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2024

Just needs rebasing

@lostella done; just curious why rebasing and not just merging the dev branch?

@lostella
Copy link
Contributor

lostella commented Feb 2, 2024

Just needs rebasing

@lostella done; just curious why rebasing and not just merging the dev branch?

whatever works :-) what I meant is to update the branch so that CI workflows run

@lostella lostella added the CI This item concerns continuous integration label Feb 2, 2024
@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2024

If possible, I would suggest dropping scikit-garden as it has been a stale project since 2017, and there seems to be no such intention for updating at least to installable without problems, see scikit-garden/scikit-garden#105 (comment)

@Borda Borda requested a review from lostella February 2, 2024 10:27
@kashif
Copy link
Contributor

kashif commented Feb 2, 2024

we can also move the pytorch version to 2.x no?

@Borda
Copy link
Contributor Author

Borda commented Feb 2, 2024

we can also move the pytorch version to 2.x no?

probably but lets make it as separate PR 🐔

lostella
lostella reviewed Feb 2, 2024
View reviewed changes
.github/workflows/pypi.yml Outdated Show resolved Hide resolved
@lostella
Copy link
Contributor

lostella commented Feb 2, 2024

If possible, I would suggest dropping scikit-garden as it has been a stale project since 2017, and there seems to be no such intention for updating at least to installable without problems, see scikit-garden/scikit-garden#105 (comment)

Yeah we should get rid of that

Borda
Borda commented Feb 2, 2024
View reviewed changes
.github/workflows/pypi.yml Outdated Show resolved Hide resolved
lostella
lostella approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lostella lostella changed the title ci: chain requirements to ensure compatibility CI: chain requirements to ensure compatibility Feb 7, 2024
@lostella lostella merged commit bff165f into awslabs:dev Feb 7, 2024
19 checks passed
@Borda Borda deleted the ci/requirements branch February 7, 2024 19:38
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Jun 15, 2024
@Borda @kashif
CI: chain requirements to ensure compatibility (awslabs#3112)
82843b5 
*Issue #, if available:* atm, all install requirements are installed as
stand-alone, which means if there is a version collision, `pip` does not
care about it, and so for eventual version compatibility, a collision
may not be discovered

*Description of changes:*
just install all needed requirements for the particular job at once so
pip sees all required packages and finds an intersection among all
:flags:


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.

cc: @jaheba @kashif @lostella kind ling as it seems there are no
revivers by default 🐿️

**Please tag this pr with at least one of these labels to make our
release process faster:** BREAKING, new feature, bug fix, other change,
dev setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostella lostella lostella approved these changes

Assignees
No one assigned
Labels
CI This item concerns continuous integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Borda @lostella @kashif