Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type annotation for device in PyTorchPredictor #3094

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

lostella
Copy link
Contributor

Issue #, if available: Fixes #3091 cc @wu462

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella requested a review from shchur December 28, 2023 13:03
@lostella lostella added the pending v0.14.x backport This contains a fix to be backported to the v0.14.x branch label Dec 28, 2023
Copy link
Contributor

@shchur shchur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lostella lostella merged commit 7835302 into awslabs:dev Jan 2, 2024
19 checks passed
@lostella lostella deleted the fix-torch-device-type branch January 2, 2024 12:02
lostella added a commit to lostella/gluonts that referenced this pull request Feb 2, 2024
@lostella lostella mentioned this pull request Feb 2, 2024
lostella added a commit that referenced this pull request Feb 2, 2024
*Description of changes:* backporting fixes
- #3094 
- #3115 

Additionally: cap pandas version to <2.2


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.


**Please tag this pr with at least one of these labels to make our
release process faster:** BREAKING, new feature, bug fix, other change,
dev setup

---------

Co-authored-by: Jirka Borovec <[email protected]>
@lostella lostella removed the pending v0.14.x backport This contains a fix to be backported to the v0.14.x branch label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The annotation of the parameter device of PyTorchPredictor is incomplete
2 participants