Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rotbaum to handle short series #3065

Closed
wants to merge 9 commits into from
Closed

Fix Rotbaum to handle short series #3065

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e17f49c
fixed bug for items with short than H history
leica2023 Nov 28, 2023
71257a6
added a test case
leica2023 Nov 28, 2023
3c06a8e
reformat
leica2023 Nov 28, 2023
1903ff2
src test styling
leica2023 Nov 30, 2023
e4f2bdb
fixed test func
leica2023 Nov 30, 2023
d4a28c3
added import
leica2023 Nov 30, 2023
0871ef7
added import
leica2023 Dec 1, 2023
d3ad48d
fixed errors
leica2023 Dec 1, 2023
08f32c6
reformat
leica2023 Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/gluonts/ext/rotbaum/_preprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ def make_features(self, time_series: Dict, starting_index: int) -> List:
prefix = [None] * abs(starting_index)
else:
prefix = []
time_series_window = time_series["target"][starting_index:end_index]
time_series_window = time_series["target"] if prefix else time_series["target"][starting_index:end_index]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include this in the previous if else above

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, makes sense.

only_lag_features, transform_dict = self._pre_transform(
time_series_window, self.subtract_mean, self.count_nans
)
Expand All @@ -477,10 +477,10 @@ def make_features(self, time_series: Dict, starting_index: int) -> List:
list(
chain(
*[
list(ent[0]) + list(ent[1].values())
prefix + list(ent[0]) + list(ent[1].values())
for ent in [
self._pre_transform(
ts[starting_index:end_index],
ts if prefix else ts[starting_index:end_index],
self.subtract_mean,
self.count_nans,
)
Expand Down
Loading