Fix iterable.Cached.
#3060
Merged
Fix iterable.Cached.
#3060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 24, 2023 14:53
jaheba
added
pending v0.13.x backport
lostella
reviewed
Nov 24, 2023
src/gluonts/itertools.py
Outdated
| cache: list = field(default_factory=list, init=False) | ||
|
|
||
| def __post_init__(self): | ||
| # ensure we only iterate once over the iterable | ||
| self._iterable = iter(self.iterable) |
There was a problem hiding this comment.
Then _iterable could be called iterator I guess
lostella
removed
the
pending v0.13.x backport
lostella
approved these changes
Nov 26, 2023
lostella
pushed a commit
to lostella/gluonts
that referenced
this pull request
Nov 27, 2023
Merged
lostella
added a commit
that referenced
this pull request
Nov 27, 2023
* Fix `iterable.Cached`. (#3060) * Torch: Remove double caching of dataset. (#3061) --------- Co-authored-by: Jasper <[email protected]>
lostella
removed
the
pending v0.14.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only cached elements that were consumed on the first iteration.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup