Add new samplers #2913
Merged
Add new samplers #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
reviewed
Jun 9, 2023
src/gluonts/transform/sampler.py
Outdated
| @@ -142,6 +162,37 @@ def __call__(self, ts: np.ndarray) -> np.ndarray: | |||
| return indices + a | |||
|
|
|||
|
|
|||
| class ExpectedNumInstanceWithMinSampler(ExpectedNumInstanceSampler): | |||
There was a problem hiding this comment.
I see two ways to escape the naming dilemma here:
- Make
min_instances: int = 0(note the default0) an attribute ofExpectedNumInstanceSamplerand add the logic directly there. Then there's no name to be invented. However, strictly speaking when one setsmin_instances > 0then this is not really samplingnum_instanceson average. - Make this logic a wrapper around some other sampler:
sampler = AtLeast(1, ExpectedNumInstanceSampler). The logic is factored a bit better maybe that way, just not as straightforward to instantiate.
Again, no strong opinions, it's just that this names is now a mouthful. @jaheba to the rescue.
There was a problem hiding this comment.
@abdulfatir let's go for option 1
added 2 commits
June 10, 2023 16:22
lostella
reviewed
Jun 12, 2023
jaheba
reviewed
Jun 12, 2023
|
I think we can just extend the current class with |
TonyHCIR
approved these changes
Jun 12, 2023
added 2 commits
June 12, 2023 10:44
lostella
approved these changes
Jun 12, 2023
jaheba
reviewed
Jun 12, 2023
|
|
||
| Parameters | ||
| ---------- | ||
| N |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR adds two new samplers:
NInstanceSamplerandExpectedNumInstanceWithMinSampler.NInstanceSampler: sample exactlyNtime points per time series.ExpectedNumInstanceWithMinSampler: same asExpectedNumInstanceSamplerbut ensures at a minimum number of time points are sampled per time series.Thanks to @lostella for code and suggestions.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup