Rework maybe.
#2593
Merged
Rework maybe.
#2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2023 10:11
* Swap operands for `map_or` and `map_or_else` such that the function argument comes before the default argument. * Add `Maybe` class so one can do `Maybe(x).unwrap()` in addition to `unwrap(x)`, etc.
melopeo
reviewed
Jan 25, 2023
melopeo
reviewed
Jan 25, 2023
|
|
||
|
|
||
| def or_(self: Optional[T], default: Optional[T]) -> Optional[T]: | ||
| if self is None: | ||
| def or_(val: Optional[T], default: Optional[T]) -> Optional[T]: |
There was a problem hiding this comment.
Can we add a small docstring to this one as it is done for the other functions?
The docstrings are the tests. |
melopeo
previously approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
map_orandmap_or_elsesuch that the function argument comes before the default argument.Maybeclass so one can doMaybe(x).unwrap()in addition tounwrap(x), etc.Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup