Fix DateSplitter for multiples of base frequencies
#2500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
added
bug fix
jaheba
reviewed
Dec 16, 2022
jaheba
reviewed
Dec 16, 2022
lostella
commented
Dec 16, 2022
jaheba
approved these changes
Dec 17, 2022
jaheba
reviewed
Dec 17, 2022
|
|
||
| The frequency is taken from ``start``. | ||
| """ | ||
| return ((end - start).n // to_offset(start.freq).n) + 1 |
There was a problem hiding this comment.
Why do you need to call to_offset here?
There was a problem hiding this comment.
Yeah I think this can be removed
| end: pd.Period, | ||
| ) -> int: | ||
| """ | ||
| Counts how many periods fit between ``start`` and ``end`` |
There was a problem hiding this comment.
Should be "count ...".
I think an example would be great
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Dec 20, 2022
Merged
lostella
added a commit
that referenced
this pull request
Dec 20, 2022
* Fix dataclass handling of member inheritance. (#2492) * Fix: sort dataset keys in error message when importing non-existing dataset (#2497) Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]> * Fix `DateSplitter` for multiples of base frequencies (#2500) * Fix docstrings according to docformatter (#2501) * Pin docformatter version. (#2507) * Docs: Fix install instructions. (#2508) * Add examples to docstring for `periods_between` (#2504) * Cap numpy compatibility in `mxnet` extra requirements (#2506) * xfail multivariate grouper test Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]> * remove undesired files * `itertools.select`. (#2426) * Add itertools select. Co-authored-by: Jasper <[email protected]> Co-authored-by: Lorenzo Stella <[email protected]> Co-authored-by: Jasper <[email protected]>
lostella
removed
the
pending v0.11.x backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #2499
Description of changes:
periods_betweento_integer_slicepointless (can be removed in a separate breaking change)TimeSeriesSlicepointless (slice_data_entryis sufficient)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup