-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up PandasDataset
further
#2441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
commented
Nov 16, 2022
I think this requires improving tests before it can be merged: for each use case for |
lostella
added
the
BREAKING
This is a breaking change (one of pr required labels)
label
Nov 16, 2022
lostella
changed the title
Speed up PandasDataset further
Speed up Nov 17, 2022
PandasDataset
further
lostella
force-pushed
the
even-faster-pandas
branch
from
November 17, 2022 09:06
1a846c7
to
4ed797b
Compare
lostella
added
enhancement
New feature or request
pending v0.11.x backport
This contains a fix to be backported to the v0.11.x branch
and removed
BREAKING
This is a breaking change (one of pr required labels)
labels
Nov 17, 2022
lostella
force-pushed
the
even-faster-pandas
branch
from
November 23, 2022 10:23
4ed797b
to
7ebe56d
Compare
jaheba
approved these changes
Nov 23, 2022
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Nov 24, 2022
Merged
lostella
added a commit
that referenced
this pull request
Nov 24, 2022
lostella
removed
the
pending v0.11.x backport
This contains a fix to be backported to the v0.11.x branch
label
Nov 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: More speedup following #2435. Testing on Python 3.8.13 with the data from #2363, using the following code:
Before the PR:
After the PR:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup