Add LongDataset. #2377
Closed
Add LongDataset. #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lostella
reviewed
Oct 19, 2022
| ) | ||
|
|
||
| yield from dataset | ||
| self.unchecked = True |
Comment on lines
+377
to
+378
| if self.translator is not None: | ||
| dataset = Map(self.translator, dataset) |
There was a problem hiding this comment.
I'm wondering whether this class is taking care of too much now: applying translator here interferes with applying column_as_start below.
There was a problem hiding this comment.
Right, but the problem is that dataframe only have 1D columns, so we need a way to stack columns. One could of course do it themselves afterwards, but since this is a more lab-focused setup I think there is an argument for having it all in one place.
lostella
reviewed
Nov 3, 2022
| freq: Optional[str] = None | ||
|
|
||
| assume_sorted: bool = False | ||
| translate: InitVar[Optional[dict]] = None |
There was a problem hiding this comment.
There’s both translate and translator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #2363 , if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup