Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up smoke tests #2341

Merged
merged 2 commits into from
Oct 5, 2022
Merged

Speed up smoke tests #2341

merged 2 commits into from
Oct 5, 2022

Conversation

lostella
Copy link
Contributor

@lostella lostella commented Oct 5, 2022

Description of changes: This reduces run time for this test to 1:20 minutes, down from 3:30 minutes, on my machine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

@lostella lostella added the tests This item concerns improving tests label Oct 5, 2022
@lostella lostella requested a review from jaheba October 5, 2022 08:42
@lostella
Copy link
Contributor Author

lostella commented Oct 5, 2022

Saved a couple tenths of seconds here and there as well

Copy link
Contributor

@jaheba jaheba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this only affect MQCNN?

Is there a reason to run for at least two epochs, to make sure that looping works?

@lostella lostella changed the title Speed up smoke test for MQ-CNN Speed up smoke tests Oct 5, 2022
@lostella
Copy link
Contributor Author

lostella commented Oct 5, 2022

Does this only affect MQCNN?

No, fixed the title

Is there a reason to run for at least two epochs, to make sure that looping works?

I don't think so, there are other tests that do training on multiple batches and epochs

@lostella lostella merged commit 5fe1696 into awslabs:dev Oct 5, 2022
@lostella lostella deleted the speedup-mqcnn-test branch October 5, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests This item concerns improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants