Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resubmit of pull request #54 #68

Merged
merged 2 commits into from Dec 28, 2021
Merged

resubmit of pull request #54 #68

merged 2 commits into from Dec 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 28, 2021

This is resubmit of pull request #54 because of revert #67 .

The followings are copied from #54 .

Issue #53 , if available:
dy ls --all-regions fails when using a table in local region, because EC2 DescribeRegions API is not available for local region.

Description of changes:
When using a table in local region,

  • issues EC2 DescribeRegions API request to us-east-1 region.
  • lists tables for local region in addition.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ghost ghost requested a review from kzym-w December 28, 2021 05:41
Copy link
Contributor

@kzym-w kzym-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@kzym-w kzym-w merged commit 8c8e191 into awslabs:main Dec 28, 2021
@ghost ghost deleted the fix_issue_53 branch December 28, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants