[fix] "dy ls" doesn't work when cache exists and table name is not specified #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…specified in both config and option.
ghost
requested a review
from 
ghost
added
the
kzym-w
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #18, if available:
dy listdoesn't work under the condition where~/.dynein/cache.ymlcontains at least one cached table and table name is not specified in both~/.dynein/config.ymland--tableoption.Description of changes:
cached_using_table_schema()(only used inlist_tables()) returnsNonewhen table name is not specified in both~/.dynein/config.ymland--tableoption.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.