Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spark benchmark observability #693

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

alanty
Copy link
Contributor

@alanty alanty commented Nov 1, 2024

What does this PR do?

increases the observability for the spark benchmark jobs:

  • enable spark metrics and eventlogging on the benchmark jobs
  • add a PodMonitor config to the kube-prometheus-stack to scrape the metrics
  • cleanup the dockerfile to avoid a warning on build

Motivation

As we've been running benchmarks the increased visibility has helped compare performance between runs.

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

@alanty alanty requested a review from vara-bonthu November 1, 2024 12:09
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vara-bonthu vara-bonthu merged commit 47405a0 into awslabs:main Nov 1, 2024
40 checks passed
@alanty alanty deleted the spark-benchmarks branch November 4, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants