Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Argo Workflow blueprint and website updated #355

Merged
merged 6 commits into from
Oct 27, 2023

Conversation

ovaleanu
Copy link
Contributor

What does this PR do?

🛑 Please open an issue first to discuss any significant work and flesh out details/direction - we would hate for your time to be wasted.
Consult the CONTRIBUTING guide for submitting pull-requests.

  • Updated the blueprint and examples
  • Updated the website

Motivation

More

  • Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
  • Mandatory for new blueprints. Yes, I have added a example to support my blueprint PR
  • Mandatory for new blueprints. Yes, I have updated the website/docs or website/blog section for this feature
  • Yes, I ran pre-commit run -a with this PR. Link for installing pre-commit locally

For Moderators

  • E2E Test successfully complete before merge?

Additional Notes

@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 26, 2023 15:29 — with GitHub Actions Inactive
@ovaleanu ovaleanu requested a review from vara-bonthu October 26, 2023 15:29
@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 26, 2023 15:38 — with GitHub Actions Inactive
@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 26, 2023 15:56 — with GitHub Actions Inactive
@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 26, 2023 16:50 — with GitHub Actions Inactive
@ovaleanu ovaleanu temporarily deployed to DoEKS Test October 26, 2023 16:59 — with GitHub Actions Inactive
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ovaleanu LGTM 👍🏼 Could you please update the region back to us-west-2

type = string
}

variable "region" {
description = "Region"
type = string
default = "us-west-2"
default = "eu-west-2"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep this region to us-west-2

@vara-bonthu vara-bonthu merged commit 5bb9050 into awslabs:main Oct 27, 2023
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants