Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding ebs volume example #132

Merged
merged 8 commits into from
Mar 15, 2023
Merged

adding ebs volume example #132

merged 8 commits into from
Mar 15, 2023

Conversation

dalbhanj
Copy link
Contributor

What does this PR do?

Adding ebs volume example for upcoming demo into emr-eks-karpenter that uses Karpenter compute provisioner.

@dalbhanj dalbhanj requested a review from a team as a code owner March 11, 2023 21:19
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 11, 2023 21:19 — with GitHub Actions Inactive
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 11, 2023 21:44 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu reviewed Mar 14, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Few minor comments

...emr-eks-karpenter2/examples/karpenter-compute-provisioner-ebs/ebs-executor-pod-template.yaml Outdated Show resolved Hide resolved
...emr-eks-karpenter2/examples/karpenter-compute-provisioner-ebs/ebs-executor-pod-template.yaml Outdated Show resolved Hide resolved
...orm/emr-eks-karpenter2/examples/karpenter-compute-provisioner-ebs/emr-eks-karpenter-ebs.yaml Outdated Show resolved Hide resolved
...orm/emr-eks-karpenter2/examples/karpenter-compute-provisioner-ebs/execute_emr_eks_ebs_job.sh Outdated Show resolved Hide resolved
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 14, 2023 20:34 — with GitHub Actions Inactive
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 14, 2023 21:00 — with GitHub Actions Inactive
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 14, 2023 21:23 — with GitHub Actions Inactive
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 14, 2023 21:27 — with GitHub Actions Inactive
@dalbhanj dalbhanj temporarily deployed to DoEKS Test March 14, 2023 21:30 — with GitHub Actions Inactive
vara-bonthu
vara-bonthu approved these changes Mar 15, 2023
View reviewed changes
Copy link
Collaborator

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vara-bonthu vara-bonthu merged commit bb0b579 into main Mar 15, 2023
@vara-bonthu vara-bonthu deleted the add-ebs-example branch March 15, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vara-bonthu vara-bonthu vara-bonthu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalbhanj @vara-bonthu