Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve types and type checks #71

Merged
merged 9 commits into from
Jul 21, 2023
Merged

Improve types and type checks #71

merged 9 commits into from
Jul 21, 2023

Conversation

peternedap
Copy link
Contributor

@peternedap peternedap commented Jul 13, 2023

Description of changes:

  • AuthenticatorParams type is now exported, making it easier to typecheck params before passing them to the handle function
  • The return type of the handle function has been narrowed to exclude undefined and null.
  • Pino dependency has been updated to a typed release
  • Type casts have been made explicit
  • Strict type checking has been enabled in the source files and explicitly disabled in the test files

@nanderv
Copy link

nanderv commented Jul 14, 2023

Nice :). This would make code I'm working on cleaner.

@jeandek
Copy link
Contributor

jeandek commented Jul 17, 2023

Hi Peter,
Thanks for your contribution. We're looking to release a new version of the package this week, so I will try to review this ASAP.
Cheers,
Jean

@jeandek jeandek self-requested a review July 21, 2023 12:27
@jeandek jeandek added this to the 1.5 milestone Jul 21, 2023
Copy link
Contributor

@jeandek jeandek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to rebase on top of the latest changes, but otherwise this looks good to me.

@jeandek jeandek merged commit 970a9c3 into awslabs:main Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants