-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional handlers and CSRF protection #68
Conversation
1. Added additional handlers for signIn, parseAuth, refreshToken and signOut 2. Added the ability to enable CSRF protection (csrfProtectionEnabled, disabled by default) 3. Added the ability to enable and customize the uri for parseAuth handler 4. Added a signOut handler that revokes tokens and clears cookies 5. handle will now log user out if the path matches the logoutUri param configured
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments about documentation, logging and one expression typo (?).
1. `handle` will now use redirect uri from decoded state param when csrfProtection is enabled 2. `logoutConfiguration` now requires `logoutRedirectUri` param 3. Updated explanation of authentication gateway setup 4. `_clearCookies` will now use redirectURI from `logoutRedirectUri`, defaulting to one from url query param and then to cfDomain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We'll merge and publish a new version as soon as we have the bandwidth.
Thanks again for your contribution!
Issue # (if available):
#65
#66
Description of changes:
handle
will now log user out if the request path matches thelogoutUri
param configuredBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.