Use refetch token, if available #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
The typing of `CloudFrontHeaders` hides the fact that there may not be a `cookie` header in the request. Previously, that would result in a `TypeError: Cannot read properties of undefined (reading 'flatMap')`. This commit updates `_getIdTokenFromCookie` to handle the situation gracefully and log the event. Co-authored-by: Jean de Kernier <[email protected]>
* Support SameSite directive similar to feat: httpOnly param awslabs#41 * Add type for SameSite * Set SameSite using existing pattern * Unit test for addition and for incorrect value validation
|
This would actually be useful, since access tokens are short-lived |
…-token-1 # Conflicts: # __tests__/index.test.ts # src/index.ts
|
Hi maverick089, I just wanted to give you a quick shoutout and say thanks for your PR! I also want to apologize for the delay in reviewing your pull request. We've had a lot going on lately and unfortunately, we haven't been able to keep up with our usual review timeline. |
borisfba
added
the
added-feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available):
Refresh Token Support #32
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.