Fix type mismatch of the status code #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeandek
requested changes
Apr 12, 2022
There was a problem hiding this comment.
Hi @piotrekwitkowski , thanks a lot for spotting the issue and submitting this PR. It looks good to me, except that you forgot to update the unit test which still expect a number to be returned. Could you fix that and submit a revised PR?
Cheers, Jean
piotrekwitkowski
force-pushed
the
fix/status-type-mismatch
branch
from
06915be to
3184a23
Compare
|
That's right, I fixed that too now. |
piotrekwitkowski
force-pushed
the
fix/status-type-mismatch
branch
from
a8933ad to
981eff2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available): Fixes #34
Description of changes:
Status property is now a string, as in the
CloudFrontRequestResult. Added return type to the handler function.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.