fix: update regex to account for idToken being last key value pair in cookie string #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available):
n/a
Description of changes:
We found that the cookie's key-value pairs order matters for this class to work properly. If the idToken is the last cookie in the cookie string, then a
;
won't be added at the end of it. However, the Regex for extracting the idToken value currently expect this to always be there.This PR updates the RegEx to account for both matching a final
;
and for matching the end of the string value.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.