Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aws-jwt-verify to verify JSON Web Tokens #15

Merged
merged 1 commit into from
Oct 22, 2021

Conversation

ottokruse
Copy link
Collaborator

Issue # (if available): N/A

Description of changes: AWS released a JWT verification library (disclaimer: I'm one of the main authors of that). This PR removes the dependency on jsonwebtoken and jwk-to-pem and instead uses the AWS JWT verification library: https://github.com/awslabs/aws-jwt-verify

Since that library has more built-in features (such as downloading and caching JWKS) I was able to remove quite a few lines from the lib here, because it has less to do now (which is good right). Test coverage has stayed the same (I notice there's a few lines of coding missing coverage, as they already did before)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ottokruse ottokruse requested a review from jeandek October 12, 2021 11:40
@jeandek jeandek added this to the 1.1.1 milestone Oct 22, 2021
Copy link
Contributor

@jeandek jeandek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Otto, looks great! We're always happy to remove code from our projects.

@jeandek jeandek merged commit 1bd14c4 into awslabs:main Oct 22, 2021
@jeandek jeandek changed the title Use aws-jwt-verify Use aws-jwt-verify to verify JSON Web Tokens Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants