Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added optional disableCookieDomain parameter #11

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

jwwheeleriv
Copy link
Contributor

* add disable cookie domain attribute as optional
 - in case app needs to exclude domain attribute
   which is more restrictive (ie. not allow subdomains)
 - defaults to false to maintain backwards compatibility
    (ie. include domain if false or not specified).

* add (Optional) to the disableCookieDomain param documentation

Issue # (if available):

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

    * add disable cookie domain attribute as optional
     - in case app needs to exclude domain attribute
       which is more restrictive (ie. not allow subdomains)
     - defaults to false to maintain backwards compatibility
        (ie. include domain if false or not specified).

    * add (Optional) to the disableCookieDomain param documentation
@jeandek jeandek merged commit 0bd6bc5 into awslabs:main Oct 4, 2021
@jeandek jeandek added the feature-request New feature or request label Oct 4, 2021
@jeandek jeandek added this to the 1.1.0 milestone Oct 4, 2021
@jeandek jeandek added added-feature For PRs which containg a new feature (may be in response to a `feature-request`) and removed feature-request New feature or request labels Oct 5, 2021
@jeandek jeandek changed the title added optional disableCookieDomain parameter (#10) added optional disableCookieDomain parameter Oct 5, 2021
@jeandek jeandek linked an issue Jan 7, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-feature For PRs which containg a new feature (may be in response to a `feature-request`)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cookie domain attribute should optionally be disabled
2 participants