Openzfs smhp - #622
Openzfs smhp#622
Conversation
b7f8691 to
873f8a1
Compare
|
Force pushed changes to revert unnecessary commits from previous PR. Also need to test behavior once on cluster without OpenZFS deployment |
|
|
I will update this PR with the changes from #633 (mentioned above) to account for the race condition. |
| Description: | ||
| Creates an FSx OpenZFS file system in addition to the FSxL file system. Default is false | ||
| Type: String | ||
|
|
There was a problem hiding this comment.
IOPS chould be configurable as well.
DiskIopsConfiguration:
Iops:
Mode:
… deployment" This reverts commit b7f8691.
282a176 to
feb876a
Compare
d277d76 to
019b2fd
Compare
|
@mhuguesaws addressed all your comments. @KeitaW if you'd like to, you should be able to test one more time before merged (already tested on local env) |
| echo "$FSX_OPENZFS_DNS_NAME:/fsx $OPENZFS_MOUNT_POINT nfs nfsvers=4.2,_netdev 0 0" | tee -a /etc/fstab | ||
| } | ||
|
|
||
| mount_fs() { |
There was a problem hiding this comment.
So much duplication. Once you add the entry in fstab, you should just do mount -a that will mount volume from fstab.
There was a problem hiding this comment.
You can also add the x-systemd.automount to automount the file system when access.
… with local cluster
edcaa5c to
711f8d5
Compare
mhuguesaws
left a comment
There was a problem hiding this comment.
LGTM.
Thank you for the feature add.
|
Tested with ansible version 6.7.0 (ansible core 2.13.13). Merging changes |
| local username=$1 | ||
| local uid=$2 | ||
| local home=$3 | ||
| local fsx_home=$3 |
There was a problem hiding this comment.
should we be more distriptive? fsxl vs fsxz?
Adding in OpenZFS option for SMHP users (LCS + create cluster setup script)
*Issue #, if available: #601 *
Description of changes:
Adding in FSx OpenZFS to be an optional home directory for SMHP SLURM users. Changes included in CF stack template, automate cluster script, and lifecycle scripts.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.