Skip to content

Openzfs smhp - #622

Merged
amanshanbhag merged 10 commits into
mainfrom
openzfs-smhp
Apr 10, 2025
Merged

amanshanbhag merged 10 commits into
mainfrom
openzfs-smhp

Conversation

@amanshanbhag

Copy link
Copy Markdown
Contributor

*Issue #, if available: #601 *

Description of changes:
Adding in FSx OpenZFS to be an optional home directory for SMHP SLURM users. Changes included in CF stack template, automate cluster script, and lifecycle scripts.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@KeitaW
KeitaW requested review from KeitaW, nghtm and shimomut March 31, 2025 14:13
@KeitaW KeitaW added the enhancement New feature or request label Mar 31, 2025
@amanshanbhag

amanshanbhag commented Mar 31, 2025 •

Copy link
Copy Markdown
Contributor Author

Force pushed changes to revert unnecessary commits from previous PR.

Also need to test behavior once on cluster without OpenZFS deployment

@nghtm
nghtm requested a review from mhuguesaws April 2, 2025 03:22
@KeitaW

KeitaW commented Apr 2, 2025

Copy link
Copy Markdown
Collaborator
Invalid value for parameter OpenZFSConfiguration.ThroughputCapacity, value: 64, valid min value: 160 (Service: AmazonFSx; Status Code: 400; Error Code: BadRequest; Request ID: 8336cfa9-2b1c-4bb6-a8ca-aeef0598553a; Proxy: null)

@amanshanbhag

Copy link
Copy Markdown
Contributor Author

I will update this PR with the changes from #633 (mentioned above) to account for the race condition.

Description:
Creates an FSx OpenZFS file system in addition to the FSxL file system. Default is false
Type: String

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IOPS chould be configurable as well.

DiskIopsConfiguration:
  Iops:
  Mode:

@mhuguesaws mhuguesaws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments

@amanshanbhag

amanshanbhag commented Apr 8, 2025 •

Copy link
Copy Markdown
Contributor Author

@mhuguesaws addressed all your comments.

@KeitaW if you'd like to, you should be able to test one more time before merged (already tested on local env)

echo "$FSX_OPENZFS_DNS_NAME:/fsx $OPENZFS_MOUNT_POINT nfs nfsvers=4.2,_netdev 0 0" | tee -a /etc/fstab
}

mount_fs() {

@mhuguesaws mhuguesaws Apr 9, 2025 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much duplication. Once you add the entry in fstab, you should just do mount -a that will mount volume from fstab.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also add the x-systemd.automount to automount the file system when access.

@mhuguesaws mhuguesaws left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Thank you for the feature add.

@amanshanbhag

Copy link
Copy Markdown
Contributor Author

Tested with ansible version 6.7.0 (ansible core 2.13.13). Merging changes

@amanshanbhag
amanshanbhag merged commit 659faf1 into main Apr 10, 2025
@amanshanbhag
amanshanbhag deleted the openzfs-smhp branch April 10, 2025 18:30
local username=$1
local uid=$2
local home=$3
local fsx_home=$3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we be more distriptive? fsxl vs fsxz?

KeitaW pushed a commit that referenced this pull request Feb 17, 2026
Adding in OpenZFS option for SMHP users (LCS + create cluster setup script)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants