Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add completions for Amazon Kinesis Stream #73

Merged
merged 1 commit into from
Dec 17, 2015
Merged

add completions for Amazon Kinesis Stream #73

merged 1 commit into from
Dec 17, 2015

Conversation

quiver
Copy link
Contributor

@quiver quiver commented Dec 17, 2015

Most Kinesis Stream API takes stream names as its parameters.
This PR autocompletes Kinesis stream names.

Usage

$ aws-shell
$ aws-shell
aws> kinesis describe-stream --stream-name <TAB> # <- completes stream names

* autocompletes Kinesis stream name
@jamesls
Copy link
Member

jamesls commented Dec 17, 2015

Thanks!

@jamesls jamesls merged commit 882742f into awslabs:master Dec 17, 2015
@donnemartin
Copy link
Collaborator

Sweet! Maybe we can take this pull request as a sample/template for community members to help with adding more server side completions? Perhaps an update to the README and/or CONTRIBUTING that makes it easier for contributors to pitch in on this effort?

@quiver
Copy link
Contributor Author

quiver commented Dec 18, 2015

@donnemartin

Perhaps an update to the README and/or CONTRIBUTING that makes it easier for contributors to pitch in on this effort?

botocore has that kind of technical documentation. https://botocore.readthedocs.org/en/latest/index.html

+1 for hacking guide

@jamesls
Copy link
Member

jamesls commented Dec 18, 2015

Yeah I'd like to add that. The server side completer is someone in flux right now.

The high level goal is to automatically derive these from boto's resource models (https://github.com/boto/boto3/tree/develop/boto3/data). The initial set of server side completions are entirely generated from boto3 resources. That being said, there's room for improvement. There's many more autocompletions we can derive from resources that aren't currently being done.

However, there's going to be times when a) the resource model doesn't have the info we need to figure out a service side completion or b) there's no resource model for a service, such as this scenario. In those cases the completions will need to be hand written.

I would like to put some "internals" documentation together for those that want to contribute.

@donnemartin
Copy link
Collaborator

👍

1 similar comment
@DanyC97
Copy link

DanyC97 commented Dec 24, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants