Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use globbing for cfn-lint, set ignore_templates #391

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .cfnlintrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
ignore_templates:
- "*/deployspec.yaml"
- "sdlf-utils/workshop-examples/60-seedfarmer/manifest-sdlf*.yaml"
include_checks:
- I
ignore_checks:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/static-checking.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@ jobs:
gem install cfn-nag
- name: cfn-lint
run: |
find . -type f -name '*.yaml' ! -name 'deployspec.yaml' -print0 \
| xargs -0 cfn-lint
shopt -s globstar
cfn-lint ./**/*.yaml
- name: cfn-nag
run: |
cat <<EOT >> .cfn-nag-deny-list.yml
Expand Down
4 changes: 2 additions & 2 deletions validate.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#!/usr/bin/env bash
set -ex
shopt -s globstar

# python
ruff format --check .
Expand All @@ -12,8 +13,7 @@ find . -type f \( -name '*.sh' -o -name '*.bash' -o -name '*.ksh' \) -print0 \
| xargs -0 shellcheck -x --format gcc

# cloudformation
find . -type f -name '*.yaml' ! -name 'deployspec.yaml' -print0 \
| xargs -0 cfn-lint
cfn-lint ./**/*.yaml

## unfortunately cfn_nag doesn't support fn::foreach so we exclude files using it: https://github.com/stelligent/cfn_nag/issues/621
find . -not \( -type f -name 'template-glue-job.yaml' -o -type f -name 'template-lambda-layer.yaml' \) -type f -name '*.yaml' -print0 \
Expand Down
Loading