Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cargo_audit_flags related to the chrono crate #646

Closed
wants to merge 2 commits into from
Closed

Remove cargo_audit_flags related to the chrono crate #646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d5b9e5
Remove cargo_audit_flags related to the chrono crate
Oct 25, 2022
5f7878e
Merge branch 'main' into ysaito/fix-cargo-audit-issue-on-chrono
ysaito1001 Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions .github/workflows/audit.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,9 @@ on:
env:
rust_version: nightly-2022-07-25

# RUSTSEC-2020-0071 , RUSTSEC-2020-0159
# chrono, a Rust date-time crate we use for timestamp parsing was added
# to the RustSec vulnerability database because of a call to localtime_r.
# We use chrono for an extremely narrow use case of converting epoch timestamps to UTC dates
# (so we never invoke the problematic behavior that results from attempting to determine
# the local time of the current platform).
#
# Chrono's only use is as an optional feature in `aws-smithy-types-convert`, for
# the narrow use-case of converting from the SDK's `DateTime` into chrono types,
# and we never invoke the problematic behavior that results from attempting to
# determine the local time of the current platform.
#
# RUSTSEC-2021-0127
# serde_cbor is being imported by criterion, a benchmarking crate. More info here https://github.com/awslabs/smithy-rs/issues/1044
cargo_audit_flags: --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2020-0159 --ignore RUSTSEC-2021-0127
cargo_audit_flags: --ignore RUSTSEC-2021-0127

jobs:
audit-latest:
Expand Down