Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Service Support: Amazon Timestream #114

Closed
sethusrinivasan opened this issue Jun 16, 2021 · 8 comments
Closed

New Service Support: Amazon Timestream #114

sethusrinivasan opened this issue Jun 16, 2021 · 8 comments
Labels
blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. new-service p2 This is a standard priority issue

Comments

@sethusrinivasan
Copy link

No description provided.

@rcoh
Copy link
Contributor

rcoh commented Jun 16, 2021 •
edited
Loading

Note: requires completion of smithy-rs#109 because timestream requires endpoint discovery to function

@rcoh rcoh added blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. new-service labels Jun 16, 2021
@overheat
Copy link

Any workaround for now, since endpoint discovery not implemented.
We want to insert records to Timestream using rust SDK.

@Velfi
Copy link
Contributor

Velfi commented Mar 28, 2022

There is no current workaround. We recognize that this is an important feature and will implement it as soon as our priorities allow.

@jmklix jmklix added the p2 This is a standard priority issue label Nov 28, 2022
@rcoh rcoh mentioned this issue May 17, 2023
Merged
5 tasks
github-merge-queue bot pushed a commit to smithy-lang/smithy-rs that referenced this issue May 31, 2023
@rcoh
Add support for TimeStreamWrite and TimeStreamQuery (#2707)
8c045d2 
TODO:
- [x] docs
- [x] integration test (canary even?)
- [x] customize README for timestream
## Motivation and Context
- #613 
- awslabs/aws-sdk-rust#114


## Description
This adds support for TSW and TSQ by adding endpoint discovery as a
customization. This is made much simpler by the fact that endpoint
discovery for these services **has no parameters** which means that
there is no complexity from caching the returned endpoint.

Customers call `.enable_endpoint_discovery()` on the client to create a
version of the client with endpoint discovery enabled. This returns a
new client and a Reloader from which customers must spawn the reload
task if they want endpoint discovery to rerun.

## Testing
<!--- Please describe in detail how you tested your changes -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
@rafalwrzeszcz
Copy link

Seems like smithy-rs already supports it - is there any update on Timestream support in Rust SDK?

@jdisanti
Copy link
Contributor

Support was added to smithy-rs, so the next full release (that is, not just a models update) of the SDK should include it. It may be a few weeks before that happens though.

@Velfi Velfi mentioned this issue Jul 5, 2023
Closed
2 tasks
@jdisanti
Copy link
Contributor

jdisanti commented Aug 3, 2023

As of the August 3rd, 2023 release, the SDK now has experimental support for Timestream. In order to use it, you MUST call .with_endpoint_discovery_enabled() on the Client after construction.

@sethusrinivasan
Copy link
Author

Thank you @jdisanti

@jdisanti jdisanti closed this as completed Apr 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. new-service p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@jdisanti @rcoh @rafalwrzeszcz @sethusrinivasan @Velfi @overheat @jmklix