Support service specific configs appearing in the general section of a profile file #1073
Assignees
Labels
Comments
8 tasks
ysaito1001
added a commit
to smithy-lang/smithy-rs
that referenced
this issue
Feb 27, 2024
## Motivation and Context Adds the ability to disable S3 Express session auth (causing it to use a regular sigv4 session auth instead). ## Description S3 Express One Zone is an opt out feature, and there are three ways to disable it (with the order of precedence as listed): - through the `disable_s3_express_session_auth` method on an S3 client - through an environment variable `AWS_S3_DISABLE_EXPRESS_SESSION_AUTH` - through a profile file with a key `s3_disable_express_session_auth` (won't be supported until awslabs/aws-sdk-rust#1073 is addressed) If one of the places is set to true/false, then the subsequent places with lower precedence will not be considered. Something to be aware of when setting the disable option through the environment variable. The environment variable is only checked during a client construction, meaning that if a customer sets it after the client has been created the SDK will not take the environment variable value into account, i.e. the following snippet will NOT disable the S3 Express session auth: ``` let config = aws_config::load_from_env().await; let client = aws_sdk_s3::Client::new(&config); // Set the env variable to true after an S3 client has been created std::env::set_var("AWS_S3_DISABLE_EXPRESS_SESSION_AUTH", "true"); let _ = client .list_objects_v2() .bucket("s3express-test-bucket--usw2-az1--x-s3") .send() .await; ``` ## Testing Added unit tests for `S3ExpressRuntimePlugin` and integration tests for verifying disabling S3 Express session auth. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._
jdisanti
added
feature-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The Rust SDK current does not support configuring following variables in a profile file
s3_use_arn_regions3_disable_multiregion_access_pointss3_disable_express_session_authExpected Behavior
If a customer puts the variable
s3_use_arn_regionin the AWS shared configuration file (by default in ~/.aws/config).and create an S3 client like so
clientshould use the ARN region instead.Current Behavior
The current behavior has no effect on the above
clienteven if the config variable is specified in a profile file. The same goes for the other variables.Reproduction Steps
Described above.
Possible Solution
No response
Additional Information/Context
No response
Version
Environment details (OS name and version, etc.)
Any
Logs
No response
The text was updated successfully, but these errors were encountered: